shazbot

@shazbot@kbin.social
shazbot,

I disabled everything and tried it with/without and saw no observable difference on the login page. Can you indicate what anomaly you are seeing in the above screenshot? Also, could you please click the clipboard icon on the bottom right of the KES menu and paste the contents of the clipboard to me in a PM so I can try to reproduce this?

shazbot,

If it occurs sporadically, it might be something failing to load on kbin's side, I have seen visual bugs like this before that are unrelated to KES. Check the dev console when refreshing the page and see if there are any warnings or errors. I will investigate regardless.

shazbot,

Truth be told, I am not sure what turbo mode is intended to be. The setting is there, but it has no description. I turned it on and observed no change. Is it different from infinite scrolling mode?

shazbot,

Thank you, I looked into it. Here is a reply I made in another thread:

By design, Greasemonkey scripts necessarily trigger on page load. However, KES initializes its own mutation observer and watches for events that change the DOM, but does so in a granular fashion so that only those of relevance (changes to the thread index and comments) are propagated. It looks like when turbo mode is enabled, the entire DOM up to the HTML tag is replaced at once, so our more granular approach is missing this change. We need to watch for basically all mutations now and filter them accordingly.

After making the necessary changes, it seems to be working again as intended, but some additional refactoring is needed, and I haven't checked the implication of this on specific scripts/add-ons yet. It looks like it should be easy enough, since the majority of functionality I looked at was working again when using a more permissive observer.

I haven't added these changes into the release version of KES, and given that turbo mode is listed as experimental, I don't think we can support it immediately over a more traditional page load structure, but at least I am aware of the issue now and can start refactoring it. Hopefully it is not problematic.

Could there be a "Filter" button for magazines?

I know there's block, but "block" currently blacklists the entire magazine. If I click on it, it wipes all the threads on /all/, prevents me from looking at threads on the magazine landing page and all comments in the threads should I venture in. A "filter" would be a soft block that just clears it from my feed on the main page....

shazbot,

Hello, I have added this feature to KES (third party extension) today. I believe it is working correctly based on your requirements:

  • Show an icon next to magazine names on the main thread index (https://kbin.social or https://kbin.social/sub if logged in). Click this icon to "softblock" threads from that magazine from appearing on your main thread index. This does not block the magazine outright: you can still go to the magazine directly, so it is less aggressive than a total block.
  • Show a Softblock/Unsoftblock button in the sidebar of magazines, as well as in the Magazines index located at https://kbin.social/magazines. As you would expect, this button has the effect of adding/removing a magazine from your filters.
  • Show a tab at the top of the Magazines index that you can use to centrally manage your softblocked magazines. For the time being, this is merely informational.

Full details can be found in the release notes here over at /m/enhancement.

Let me know if this gives you the functionality you wanted.

shazbot,

Would you like to add this to KES? You can use KES' propagation feature to ensure it applies to comments loaded in on the fly when infinite scrolling is enabled without needing to worry about page load events.

May I also suggest something more idiomatic like the below?

const code = document.querySelectorAll('pre code');
const reg = /^\n<span style="color:#323232;">/g
const reg2 = /\n<\/span><span style="color:#323232;">/g
const reg3 = /<\/span>\n$/

code.forEach((block)=> {
    let str
    str = block.innerText;
    str = str.replaceAll(reg, "");
    str = str.replaceAll(reg2, "\n");
    str = str.replace(reg3, "");
    block.innerText = str;
});
shazbot,

If you need help packaging it, let me know. Can prepare it and credit you. Setting up infinite scrolling in KES just requires one line (recurs: true in the manifest) and KES will take care of spawning observers automatically.

By the way, what is turbo mode, exactly?

shazbot,

Thanks, this was helpful. By design, Greasemonkey scripts necessarily trigger on page load. However, KES initializes its own mutation observer and watches for events that change the DOM, but does so in a granular fashion so that only those of relevance (changes to the thread index and comments) are propagated. It looks like when turbo mode is enabled, the entire DOM up to the HTML tag is replaced at once, so our more granular approach is missing this change. We need to watch for basically all mutations now and filter them accordingly.

After making the necessary changes, it seems to be working again as intended, but some additional refactoring is needed, and I haven't checked the implication of this on specific scripts/add-ons yet. It looks like it should be easy enough, since the majority of functionality I looked at was working again when using a more permissive observer.

shazbot,

Hi, this feature is still available and working in KES under Threads > Permanently Hide Posts. The hide link appears next to the more button, not inside of the more menu. Give it a try.

shazbot,

If you are using KES, you can navigate to Threads > Permanently hide posts to enable the option to hide threads from your feed

shazbot,

If you install KES and navigate to the setting Threads > Rearrange post order, you can dynamically change the position of the OP, the comments, the add comment box, and other elements and choose which place you want them to be in descending order. You can direct other questions to our magazine on /m/enhancement as well.

Clicking on a notification (e.g. a user's reply to my comment) does not take me to the proper place in the comment section of a thread if the thread has multiple pages of comments.

I have to try each page and scan the entire thread for my avatar in order to find the exchange the notification was telling me about. It would be very nice if the notification link just jumped directly to the reply.

shazbot,

I used to have this issue, but I don't have it anymore. Notifications jump to where they should; the links point to specific comment IDs within a thread. Can you list steps to reproduce it? What do your notification links look like?

shazbot,

Good catch, it seems that if there are multiple pages of comments, it won't take you there because of the pagination.

shazbot,

This is now live in 2.2.0, see here

shazbot,

Please have a look at KES. The latest version, released today, includes a featured called the "subscriptions omnibar" that allows you to summon a searchable, filterable list of your subscriptions at a keypress and jump to one. This feature is detailed in this thread and looks like this

shazbot,

As promised, I have added something called the subscriptions omnibar to the latest version of KES that allows you to open a list of your magazines at a keypress and search/filter through them, then jump to one instantly. Details are here

shazbot,

Are you trying to search for it from within Tampermonkey? You should navigate to the KES page and install it directly from there.

shazbot,

2.2.0 was released today, so you should be installing via here

This is good feedback, wasn't aware of the auto images feature. Will investigate how it works and issue a fix.

shazbot,

Yes, I just tested it and the issue was quite clear. I have the fix complete and ready to go here, just want to test it a bit to make sure there are no unforeseen effects.

shazbot,

Alright, this should be fixed with version 2.2.2 if you update again.

shazbot,

It's a known limitation, won't get into the technical reasons therefor, but will continue trying to narrow this gap to remove the blink.

  • All
  • Subscribed
  • Moderated
  • Favorites
  • •
  • JUstTest
  • mdbf
  • InstantRegret
  • ethstaker
  • magazineikmin
  • GTA5RPClips
  • rosin
  • modclub
  • Youngstown
  • ngwrru68w68
  • slotface
  • osvaldo12
  • kavyap
  • DreamBathrooms
  • Leos
  • thenastyranch
  • everett
  • cubers
  • cisconetworking
  • normalnudes
  • Durango
  • anitta
  • khanakhh
  • tacticalgear
  • tester
  • provamag3
  • megavids
  • lostlight
  • All magazines
    •