j3j5, (edited )
@j3j5@hachyderm.io avatar

Question for my fellas:

Do you think Bus::dispatch()and dispatch() behave exactly the same? Should they?

Boosts appreciated, obviously :)

j3j5,
@j3j5@hachyderm.io avatar

We're getting close to finishing so I'll expand. While fixing a bug on the rector-laravel package, I find out that you can queue closures using dispatch (as per the docs) but you can't when using Bus::dispatch(). I thought this was a bug but I got the issue closed (probably for not being assertive enough, haha). What do you think?

https://github.com/laravel/framework/issues/51150

michael,
@michael@thms.uk avatar

@j3j5 lol. Classic laravel response there 🙄

j3j5,
@j3j5@hachyderm.io avatar

@michael lol, I know 🙃 worst part is that it's got way better with the years, it used to be much worse in the past 🤷

michael,
@michael@thms.uk avatar

@j3j5 I actually managed to get a PR merged recently, but yeah, you gotta have quite thick skin (and be quite deferential, which doesn’t come naturally to me 😬)

j3j5, (edited )
@j3j5@hachyderm.io avatar

@michael yeah, not my first rodeo and I keep reporting making PRs because I still benefit from them. I can understand from the other side, a repo like that isn't easy to manage, but that's why I try to make the issues and PRs as clear as possible. I think in this case Dries didn't read past the "not 100% sure if it's a bug" 🤷

  • All
  • Subscribed
  • Moderated
  • Favorites
  • Laravel
  • kavyap
  • normalnudes
  • everett
  • DreamBathrooms
  • ethstaker
  • magazineikmin
  • thenastyranch
  • Youngstown
  • GTA5RPClips
  • slotface
  • khanakhh
  • vwfavf
  • rosin
  • mdbf
  • provamag3
  • Leos
  • Durango
  • tacticalgear
  • InstantRegret
  • cubers
  • osvaldo12
  • ngwrru68w68
  • anitta
  • tester
  • modclub
  • cisconetworking
  • megavids
  • JUstTest
  • All magazines