RTR#31 Further refactoring, update Symfony to 6.4 and other deps

ThatOneKirbyMain2568, 5 months ago

Great changes! A spoiler tag button is really nice, especially since the formatting for it can be a bit clunky. On that note though, I think it'd be nice to have an alternate format for making spoilers that doesn't literally have the word spoiler in it.

It's also awesome to see that official collections are explicitly marked, but the way it's done is rather odd. It's a button that creates an "Are you sure?" prompt on the screen when you click it. It seems like something that's meant for instance owners.

I think something less obtrusive next to the collection's name would be better for marking official collections. I implemented that with a checkmark in my userstyle, and I prefer it to the button. Maybe have the text "official" show when you hover over it to indicate what it means.

cacheson, 5 months ago

::: spoiler Like this?
Do you mean just displaying something other than "spoiler" in the header? Or not using the word "spoiler" when writing the tag at all? If the latter, I believe it's done that way to match how it works on lemmy.
:::

ThatOneKirbyMain2568, 5 months ago

I mean not having the word spoiler when writing the tag. I get that it's done for Lemmy compatibility, which is why I suggest an alternative way to do it (like how italics can be written like _this_ or like *this*).

DessertStorms, 5 months ago

(like how italics can be written like this or like this).

How do you get that to display without italicising/bolding the text? (E: like has clearly happened to me lol)

ThatOneKirbyMain2568, 5 months ago

Backslashes. To get _this_, you type \_this\_. In fact, you can backslash backslashes, which is how I showed the backslashes here.

DessertStorms, 5 months ago

Amazing, thanks!
(now to hope I actually remember lol)

Kierunkowy74, 5 months ago

StackExchange Flavoured Markdown features spoilers done like this:

>! Hidden text

! Hidden text

Well, @ernest is aware of way, how spoilers are done on Wykop, being simply ! Hidden text

ThatOneKirbyMain2568, 5 months ago

True, though this doesn't give the spoiler a header.

Maybe something like ||header|content||, based off how Discord handles spoilers, could work.

So

::: spoiler don't click if you're 8 or younger
santa isn't real
:::

could be written as

||don't click if you're 8 or younger|santa isn't real||

Edit: Backslashing doesn't seem to work on colons for whatever reason, so I removed that example of how the spoiler could be written.

DessertStorms, 5 months ago (edited 5 months ago)

nope

::: spoiler spoiler
testing
:::

(E: I've tried several ways to get it to work, once I got the little triangle but also the word "spoiler" on the end, the rest of the times I got variations of what it looks like now. Am on desktop)
(E2: it's now settled on a little triangle, it was showing the ::: bits before, I swear 😂)

DessertStorms, 5 months ago

I've found where to create a collection, but where do I view those already created by others? And is that really the main difference between a collection and my subscribed feed, that they can be shared?

Pamasich, 5 months ago

Go to the Magazines tab in the top bar and then there's a collections tab on the page that opens.

DessertStorms, 5 months ago

Ah, thanks!

daredevil, 5 months ago

The "Add New" button is a nice update to the #Collections page -- should be useful for #discoverability and accessibility which hopefully inspires others to use this feature! Also glad to see that unfollowing a #Collection has been renamed from "Delete" to "Unlike". The spoiler tag update is also definitely welcome.

tjhart85, 5 months ago

As always, your work is fantastic, @Ernest!

Having that spoiler tag available in the editor will be great, especially on mobile!