jonthegeek, 3 months ago

@yjunechoe They're failing to render for me on the pkgdown site. The images load when I open them in a new tab, but I haven't dug deeper than that.

jonthegeek, 3 months ago

@yjunechoe Ok, I dug SLIGHTLY deeper. Console is showing messages like this:
🚫 GET https://yjunechoe.github.io/jlmerclusterperm/man/figures/README-/setup-io-dark.svg 404 (Not Found)

yjunechoe, 3 months ago

@jonthegeek Oh interesting! Let me re-render the whole site (and not just the home) to see if that goes away 🙃

FWIW it works if you swap out "/man" for "/reference" in the broken URL - https://yjunechoe.github.io/jlmerclusterperm/reference/figures/README-/setup-io-dark.svg

That's where the link should point to for dark mode imgs. Maybe the light/dark mode auto-switch is only designed to work with github out of the box, and need extra care for it to work in pkgdown... Will dig into it!

gaborcsardi, 3 months ago

@yjunechoe @jonthegeek On pkgdown we can render the output as HTML, look at how the callr package does it:
https://callr.r-lib.org/

Look at the README.Rmd, and also
https://github.com/r-lib/callr/blob/0efcb01644f910ef765d92889664537a0050a388/.github/workflows/pkgdown.yaml#L22
https://github.com/r-lib/callr/blob/0efcb01644f910ef765d92889664537a0050a388/.github/workflows/pkgdown.yaml#L34-L45

yjunechoe, 3 months ago

@gaborcsardi @jonthegeek Oh wow this is great!! Thanks for the pointers!

gaborcsardi, 3 months ago

@yjunechoe @jonthegeek Np. Let me know if you have issues.

Btw. bonus feature: on GH you get light images in light mode and dark images in dark mode: https://github.com/r-lib/callr#readme