bookwar,
@bookwar@fosstodon.org avatar

I really really don't get how people can complain about Gerrit Code Review interface, if they ever used GitHub Code Review UI.

Just go to a completely random PR and try to find a comment from the reviewer on the page:

https://github.com/kubernetes/ingress-nginx/pull/10984

And this is our "industry standard" which everyone tries to replicate?

minkiu,
@minkiu@mastodon.social avatar

@bookwar do you have a gerrit example in hand to compare?

bookwar,
@bookwar@fosstodon.org avatar

@minkiu

Check any change on review.opendev.org

For example https://review.opendev.org/c/openstack/requirements/+/907647?tab=comments

mirek,
@mirek@rodina-sucha.cz avatar

@bookwar @minkiu Am I weird when I like GitHub interface more? It works for me. As long as the PRs are small. And when PR is big then the problem is in the project/author/language.

bookwar,
@bookwar@fosstodon.org avatar

@mirek

No, you are not :)

As long as PR is small and CI and review processes are simple.

Indeed, if you are doing a simple change in a simple project, GitHub gives you a simple view. (Which still can be compacted from 5 different pages with a lot of whitespace to a singe screen)

But once you get more than one CI, more than one conflicting MR, more than one label and more than one bot, it becomes a mess.

It just doesn't have enough functionality for that.

@minkiu

michelin,
@michelin@hachyderm.io avatar

@bookwar @mirek @minkiu once the PR is big nothing beats Phabricator IMHO ... sad the open source version didn't succeed as a busine..

bookwar,
@bookwar@fosstodon.org avatar

@michelin

I wonder if forgejo folks consider the possibility of a pluggable UI. So that we can try different options, including those inspired by less known Code Review systems.

I wouldn't even try to claim that I know the best way to do a UI. I am just really tired that we don't get to experiment on which way may be better than a GitHub look-alike.

@mirek @minkiu

vwbusguy,
@vwbusguy@mastodon.online avatar
vwbusguy,
@vwbusguy@mastodon.online avatar

@bookwar @michelin @mirek @minkiu The UI is templated, so it's possible for that template to be expanded, but the problem appears to be that the UI template might regularly change, so the UI plugin versions might need to be tied to the @forgejo version.

vwbusguy,
@vwbusguy@mastodon.online avatar

@bookwar @michelin @mirek @minkiu @forgejo For what it's worth, I've had a similar thought about this for Wiki pages in Forgejo/Gitea - that extending the functionality to allow for dynamic content or alternative WYSIWYG editors or a two-way XWiki sync could be useful.

drewdevault,
@drewdevault@fosstodon.org avatar

@bookwar gerrit's code review interface is super good

  • All
  • Subscribed
  • Moderated
  • Favorites
  • random
  • DreamBathrooms
  • magazineikmin
  • everett
  • InstantRegret
  • rosin
  • Youngstown
  • slotface
  • love
  • khanakhh
  • kavyap
  • tacticalgear
  • GTA5RPClips
  • thenastyranch
  • modclub
  • anitta
  • mdbf
  • tester
  • Durango
  • ethstaker
  • osvaldo12
  • cubers
  • ngwrru68w68
  • provamag3
  • normalnudes
  • Leos
  • cisconetworking
  • megavids
  • JUstTest
  • All magazines