I'm experiencing first hand the beauty of, ahem, "legacy" code in prod. Four code blocks in a row that insert a break statement... After a return one; up to 13 levels of nested if- else if blocks (something so common my colleagues call that figure the "Doritos"); one class with a couple of thousands lines which has class declarations in the middle of pure spaghetti functions; TODO comments from a decade ago; functions with 3 (!) different declarations to perform the same exact logic... 1/2
@fedops There's a VS Code plugin which does the magic of showing up who and when did the last commit on the line you put the cursor on. As Jim Morrison put it, "No one here gets out alive". XD
The comments are neverending fun, too. I've seen one which goes something like, "[Name of one of their colleagues], I've done [this and that, pretty weird stuff] so maybe we can bypass [something they didn't really understand] and [hopefully fix the mess they were requested to fix]". XD
@tulpa@fedops I have a colleague which, as far as I can judge, is quite brilliant. And today it's the third time in a row that happened to him that, fixing some frontend code in production, he's breaking something else, no matter code reviews. This is a whack-a-mole game against a hydra monster, so yes, any code just needs to grow to some critical point to be terrible indeed. No code review can't do much against that, it would seem; so maybe they just admitted that to you. ;)
To be fair, this is a monster which has been fed for decades by very different people. And me, as newbie as I am, can't brag about doing this much better. Well, maybe a little better, as I can at least see what is obviously wrong. But this does calm the impostor syndrome a bit, so everything's fine. ;)
Anyway, I'm incredibly happy with $newJob, really enjoying the workplace and colleagues. And, better or worse codebase, I'm really having fun playing with it. :D 2/2
@joel Very fun indeed, and the people in the workplace is very cool, I haven't felt any pressure yet (no need, I can put more than enough pressure on myself!) XD
@array I need some of that positivity cake. I'm also on a code base with nested everything , copies of variables of variables somewhere and global variables are tha bomb. :) I just can't stand it.
@supernov For me, it's easy: I just have to compare with what have been my jobs until this point. A clue: this is the first one I can do sitting in a chair. ;)
Add comment