angelikatyborska,
@angelikatyborska@mas.to avatar

Based on my experiences in various frontend codebases that were written without a frontend expert on the team (including my own old projects 💩), I compiled a list of 9 most common signs of frontend code quality issues that affect users https://angelika.me/2024/04/13/9-signs-your-frontend-code-has-quality-issues/

syntaxseed,
@syntaxseed@phpc.social avatar

@angelikatyborska This is a fantastic article!

I just wish it had a brief line on each item about the recommended way to do it instead. Because now I'm left scratching my head on a few of these... 🤔

angelikatyborska,
@angelikatyborska@mas.to avatar

@syntaxseed For each point, I added links to my favorite articles that explain the topic and what's the correct thing to do. I believe a full article is necessary for each point - a single sentence is not enough to explain the nuance of some of these topics.

syntaxseed,
@syntaxseed@phpc.social avatar

@angelikatyborska Oooo. I thought the links were for the proper use of the misused elements... not the proper way to do the thing being attempted. 😁

marcus,
@marcus@mastodon.social avatar

@angelikatyborska Unsurprisingly, nearly all are accessibility topics.

tennoseremel,
@tennoseremel@lor.sh avatar

@angelikatyborska
> 5. Using the title attribute

…is not bad, provided it's not the only source of information.

> 6. Removing button outlines

…is also fine, provided it is replaced with something else equally obvious.

sarajw,
@sarajw@front-end.social avatar

@tennoseremel
If the title text is provided somewhere else, not only for mouse users (so sighted keyboard or switch users can access it as well as screen readers), why have it also in title?

Button outlines or borders are needed for forced colors - if both are removed then the button may not be obvious at all for the people who really need it to be. Best to restyle the outline than remove it.

@angelikatyborska

tennoseremel,
@tennoseremel@lor.sh avatar

@sarajw Another example for titles could be fixed buttons, like menu, increase font size or text width, etc. since they cannot take too much space. TBH, browsers could do a better job supporting title attribute… 🤔

@angelikatyborska

sarajw,
@sarajw@front-end.social avatar

@tennoseremel @angelikatyborska it'd be nice if title and aria-label were more coupled, but I guess that would cause other issues...

sarajw,
@sarajw@front-end.social avatar

@tennoseremel @angelikatyborska either way thanks for the replies! But I still agree that those two points as given in the list of nine are still often signs of a dodgy choice in the front end - unless they're being used in the very narrow and thoughtful way you suggest :)

tennoseremel,
@tennoseremel@lor.sh avatar

@sarajw Well, I suppose, rules like these should be read more or less as “unless you know what you are doing”, but you still need to know there might be problems in the first place, so it's good to have some :blobcatcoffee:

@angelikatyborska

sarajw,
@sarajw@front-end.social avatar

@tennoseremel @angelikatyborska yes, arguably this list isn't for the likes of us, although I'm always going through them anyway because I often learn something new.

  • All
  • Subscribed
  • Moderated
  • Favorites
  • webdev
  • kavyap
  • mdbf
  • osvaldo12
  • ethstaker
  • tacticalgear
  • DreamBathrooms
  • thenastyranch
  • magazineikmin
  • modclub
  • Youngstown
  • everett
  • slotface
  • rosin
  • GTA5RPClips
  • JUstTest
  • khanakhh
  • cisconetworking
  • tester
  • ngwrru68w68
  • normalnudes
  • Durango
  • InstantRegret
  • cubers
  • provamag3
  • anitta
  • Leos
  • megavids
  • lostlight
  • All magazines