@stsquad I think some of the cons of the email based systems are that you can easily lose a patch with no one reviewing or merging it; most of the forge based systems are better at tracking patches in flight. The forge based systems should be doing line-by-line review most do don't they?
@penguin42 yeah this is where tooling helps. #patchew helps tame the mess of searching your email feed to find series missing reviews.
When I talk about line by line I mean at the commit level. In most forges I end up reviewing stuff on the PR diff view which is fine if PRs are small and self contained. We do suffer somewhat in #qemu by having some mega-cleanup series which is a lot to wade through.
@stsquad Yes, the forges seem to be quite opinionated about whether you should be working at PR or commit level; which is a shame since it varies by task. Geritt is quite nice at the individual commit level but has very little at a PR layer. I find Gitlab the opposite - flexibility would be nice. I didn't find patchew helped me that much.
Add comment