awoodsnet, 7 months ago (edited 7 months ago)

@codewiz one problem that almost all themes suffer from, is low contrast. This makes them hard to read. I understand that they’re trying to keep the focus on the operational code. Some will say it’s aesthetically pleasing – but why make things harder on yourself? this medium gray text on black background has to go.

Instead, make block comments collapseable. that way they could be expanded and read easily when needed

codewiz, 7 months ago

@awoodsnet Indeed, that's why I went with github_dark_high_contrast, which perhaps has too much contrast.

This is the demo screenshot. I customized a few things and I'm quite pleased with the mechanism to override palette elements and highlight groups.

awoodsnet, 7 months ago

@codewiz i don’t think it’s too much contrast. I do think the comments should look different from normal text. Comment that are just a shade or 2 darker might be enough. Adding a slight golden or pink tint might help to distinguish comments

codewiz, 7 months ago

@awoodsnet @dpom I tweaked the github theme to be closer to what I was used to with vim's default colorscheme.

This is what it looks like with Rust (left) and Lua (right). Notice the subtle inlay type hints for Rust and the git markers on the right.

dpom, 7 months ago

@awoodsnet @codewiz Contrast is a deeply personal aspect of theming. What's interesting about contrast, is that users report a sensation of eye strain with both too much and too little, and the Goldilocks amount of contrast seems to vary considerably between users. The issue of whether comments should have less contrast than other syntax (or just a unique color) is a separate issue, and also rather contested, it seems.

My theme is here, if you'd like to take a look:

https://github.com/dustypomerleau/tol.nvim