afilina, 5 months ago

@heiglandreas I am still bothered that the discussion on that interface has my name attached to it, even though that is not the interface that I proposed in my conference talk. I proposed a single now() method.

heiglandreas, 5 months ago

@afilina Well... The interface has a single now() method?

I know it. I fought hard for it....

afilina, 5 months ago

@heiglandreas Oh it does!? How wonderful. Thank you for fighting for it!

heiglandreas, 5 months ago

OK. I caused that!

It had nothing to do with Symfonys (or any other) Clock implementation!

A broken DI-config in combination with a hard-coded DI-dependency in tests caused the System-Clock implementation to not be replaced by the test-clock.

That the default was Symfonys implementation was just a coincidence...

🙈

I think it's time to call it a day and start the holidays!

SenseException, 5 months ago

@heiglandreas 🥂🍾

doppynl, 5 months ago

@heiglandreas did they ignore the psr again?

heiglandreas, 5 months ago

@doppynl Nope!

While I still think that there are enough Clock-implementations out there, their implementation is totally sane and OK.

It is just the default when you do not set up any other implementation of the ClockInterface in symfony.

And I seem to have accidentally removed that declaration, which was why I got that default implementation.

https://phpc.social/@heiglandreas/111623977024585390

afilina, 5 months ago

@heiglandreas @doppynl That's why I'm not really a fan of automatic aliasing.

wouterj, 5 months ago

@doppynl I guess we'll forever be reminded that we partially ignored 1 of the 20 PSRs because we can't support it even if we wanted it?

heiglandreas, 5 months ago

@wouterj I am also missing the PSR-8 implementation in symfony!

Which gives me hope that one day we will see a native PSR-7 and PSR-15 implementation in symfony. 🎉

And perhaps even a symfony representative in the FIG again? 😉 symFIGny!

/cc @doppynl

smoench, 5 months ago

@heiglandreas @wouterj @doppynl PSR-7 is possible with symfony controllers but you need to install a bridge and enable following config https://github.com/symfony/recipes/blob/18a02c4e5b3e9fba970a1b11b02d2fcd4599895f/symfony/psr7-pack/1.0/config/packages/psr_http_message_bridge.yaml#L15

heiglandreas, 5 months ago

@smoench I know.

But it's not what I consider native 😉

/cc @wouterj @doppynl

wouterj, 5 months ago

@heiglandreas @doppynl it's the best we can do unfortunately.

I'm pretty sure you know already, but Symfony itself - and most of the bundles and code written in the ecosystem - rely on mutable requests (and to lesser extent responses).

Changing this will be a massive cost for the ecosystem. To be honest, I haven't seen an issue or heard anyone in the community talk about wanting more than the PSR-7 bridge (let alone leading such a big project).

heiglandreas, 5 months ago

@wouterj Oh I don't think it's worth the effort now. That would indeed be a huge task and mean a break with everything.

It might have been possible when PSR 7 was fresh, but decussiins were made and now we live with that.

/cc @doppynl