robinlovelace, 5 months ago

Thanks to @mattlehrer this is now fixed 🎉

#OpenSource community is amazing, gratitude to Matt and everyone in this space. For the benefit of others, here's the fix in the open: https://github.com/cruse-bike/cruse/pull/9

video/mp4

phoopee3, 5 months ago

@robinlovelace @mattlehrer I've never seen syntax like that - e.detail?.center - is that checking if .center is defined on e.detail? I didn't know you could do it that way!

mattlehrer, 5 months ago

@phoopee3 @robinlovelace it’s checking for the existence of both e.detail and e.detail.center with “optional chaining” https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Optional_chaining

mattlehrer, 5 months ago

@robinlovelace I’m happy to help and liked working with leaflet and openstreetmaps data in svelte. I don’t recognize the tiles in the screenshot though. What are you working on/with and what do you want help with?

robinlovelace, 5 months ago

@mattlehrer many thanks will be in touch soon

robinlovelace, 5 months ago

@mattlehrer Hey Matt, more detailed answer now at my desk. We're working with MapLibre via svelte-maplibre. Current issue seems to be a bit of a fiddly one: search bar freezes after flying to place name as shown in video and described in this issue: https://github.com/cruse-bike/cruse/issues/8 Contributions welcome and happy to chat over.

video/mp4

aeischeid, 5 months ago

@robinlovelace maybe I am a little rusty on svelte with all the new parts that have released lately, but sounds like interesting stuff and I'd be happy to discuss

robinlovelace, 5 months ago

@aeischeid OK great! Well I'm just getting going so any input appreciated. Good news, got a basic map up and running! https://cruse-bike.github.io/cruse/ However, got an issue that I cannot see how to resolve: the geocoding bar is in the wrong place. Any ideas? Have tried everything I can think of to fix it including in the <style> section.

robinlovelace, 5 months ago

@aeischeid See here a link to the source code: https://github.com/cruse-bike/cruse/issues/4

aeischeid, 5 months ago

@robinlovelace I'll take a look this evening once I can get to a computer

aeischeid, 5 months ago

@robinlovelace not sure where you'd like to put it but I found a way to control it. Little tricky since it is a component of a dependency

basically add and id or class on it then in the style block reference it with :global(.geoCodeControl) {margin: 20px 50px;}

something on that order.

can try to open a PR if you like

aeischeid, 5 months ago

@robinlovelace opened a couple PRs. Hope it helps you out!

robinlovelace, 5 months ago

@aeischeid Amazing and greatly appreciated 🙏