A surprisingly common mistake people do when contributing to #OpenSource projects is to forget the (often required) sign-off on their commit, and then close the PR only to open a new one where the sign-off is included. This isn’t needed! Next time, just:
git commit --amend --signoff
git push --force
And your signoff will be added to the commit in your PR.
@castarco not necessarily better :) See the comment from @klausman earlier in this thread:
> as the git-config manpage rightly points out -- signing off should be a conscious act
There are many ways to automate a sign-off, but it’s arguably no longer a signoff then. I mean, not like anyone would know, just saying it wouldn’t be considered better by many, but worse.
The whole DCO thing being silly seems to me like the most rational take to me 😅
@johanneskastl Sure! My point was mainly that most often one PR == one commit, in our project. So there's only really one commit to sign off on at the end of the day :) Other projects do things differently of course.
@anderseknert I worked for a long time on a sign off required project. I like what it does but the workflow is terrible, especially for new contributors.
@linux_mclinuxface totally! Just curious, what is it that it does that you like? 🙂 I work for such a project, and it just seems to cause more harm than good. But I could be missing some benefit.
@linux_mclinuxface uncontroversial, I’m sure, but what value do they add from a law POV? A sign off on a commit is just repeating information that was already there, and it’s not like donald@duck.com signing off on a commit helps assert an actual person is connected to that action, no?
@anderseknert Well, the sign off by itself doesn't do anything much, but paired with item D in the DCO and the conscious act of signing gives it legs (again, IANAL)
@anderseknert One of the problems is that -- asthe git-config manpage righlty points out -- signing off should be a conscious act, but there is no (current) mechanism that tells the user upon opening the PR (BEFORE creating the PR visibly to others) that says "Hey, if this is gonna be merged, it needs signoff, add that now?"
I suspect someone somewhere already has a hook mechanism for that :)
@klausman for sure! I suppose any commit without a sign-off could be rejected at push, but people often work on a bunch of commits and then squash into a final one for the PR which is signed, so damned if you do, damned if you don’t 😄
Add comment