John_Livingston, 3 months ago (edited 3 months ago)

Feel free to send me your comments, or even to propose some pull request by correcting directly this file:
https://github.com/JohnXLivingston/peertube-plugin-livechat/blob/main/support/documentation/content/en/technical/slow_mode.md

John_Livingston, 3 months ago (edited 3 months ago)

I have a working implementation as a Prosody module.
Once the XEP will be submitted, i will add it to the prosody-modules repository.

Code is here:
https://github.com/JohnXLivingston/peertube-plugin-livechat/tree/main/prosody-modules/mod_muc_slow_mode

John_Livingston, 3 months ago (edited 3 months ago)

I also have some ConverseJS code, but it is not very clean.

Once the XEP submitted, i will propose to integrate it upstream.

jssfr, 3 months ago

@John_Livingston Woop woop, good work!

(Long-time editor and XSF council member here.)

This is looking pretty decent already. Only nitpick I have is that "CAN" is not an RFC 2119 word, and you should replace it with MAY or SHOULD (whichever fits best).

Some of the wording feels a bit strange to me, but as I'm not a native English speaker either, I'm not going to try to fix that :). Maybe someone else will step up?

The rest will probably come with discussion in the XMPP community on the standards mailing list.

If you need further help on the process, feel free to ping me :).

P.S.: I nearly didn't see your post because you didn't switch the language to English before posting :).

John_Livingston, 3 months ago

@jssfr
Thanks for your feedback!
I already fixed some RFC 2119 wording, will check again.

Oops for the french language on the post, i just edited it to set to english. My bad.

Thanks again. I love so much the XMPP community: always here to help :)

debacle, 3 months ago

@John_Livingston @jssfr

Nice feature!

I wonder, if moderators should be excepted from the rate limit, too, not only administrators and owners?

That might help, when moderation is actually needed.

larma, 3 months ago

@John_Livingston love the work so far. 👏

I second @debacle's comment re who should be exempted from rate limit. Instead of tying to the owner/admin affiliation, I would tie this to the moderator role (which owner/admin typically possess, but others might as well). A moderator not slowing down when intended to do so should probably not be a moderator anymore ;)

John_Livingston, 3 months ago

@larma @debacle
Agree. When i read the MUC XEP again, i thought that moderator and admin are the same. But maybe i'm wrong. I'll check that.

sachinsaini, 3 months ago

@John_Livingston this will be very good if implemented across clients as well as it will allow you to manage I guess groups one like telegram

John_Livingston, 3 months ago

@sachinsaini
The good thing with this proposal: it will work, and is already configurable, in xmpp clients !
The only missing part is some UI to tell users there is a limit, before they hit it.

John_Livingston, 3 months ago

@sachinsaini
For Prosody servers, you just have to put the module in the right directory, and enable it on the room virtualhost :)

sachinsaini, 3 months ago

@John_Livingston maybe it will be implemented in clients like conversations

John_Livingston, 3 months ago

@sachinsaini
yep! hope so!

I have a dirty implementation for ConverseJS. I will propose to make a cleaner implementation upstream when the XEP will be officially published (as a draft)