alessandrolai, 8 months ago

@kboyd right?? Refactoring toward enums is so so satisfying!

kboyd, 8 months ago

@alessandrolai I was able to consolidate a bunch of user status variables/constants/strings together into a single source of truth. So nice.

Even worked alright in twig, where I could compare to constant('\Path\To\Enum::Value')

cabbey, 8 months ago

@kboyd @alessandrolai I have a couple in a feature dev branch at work. Gotta admit they’re pretty damn nice to code with, way better than const ints. Only gripe I have so far is that I can’t put them into log messages or context or even simple echos without doing some kind of special one off weirdo function on it and calling that. One of the few places I want a $@&*^£ magic __toString() but we can’t have it. :(

kboyd, 8 months ago

@cabbey @alessandrolai You mean ->name and ->value?

kboyd, 8 months ago

@cabbey ooh, you can check "instanceof BackedEnum", so monolog could be updated to grab the ->value and ->name in that case (if it hasn't already)

cabbey, 8 months ago

@kboyd sounds like a context processor. Could also handle casting bools as ‘T’ or ‘F’ instead of ‘1’ and ‘’.

alessandrolai, 8 months ago

@cabbey @kboyd can't you manually implement \Stringable on them?

cabbey, 8 months ago

@alessandrolai @kboyd nope php spews an error. https://3v4l.org/4YUXC#v8.2.10

alessandrolai, 8 months ago

@cabbey @kboyd aw crap, it's covered in the original RFC:

"However, implicit magic method calls such as ArrayAccess on enums are not allowed in static or constant definitions as we cannot absolutely guarantee that the resulting value is deterministic or that the method invocation is free of side effects. Function calls, method calls, and property access continue to be invalid operations in constant expressions."

https://wiki.php.net/rfc/enumerations

cabbey, 8 months ago

@alessandrolai @kboyd yeah. I just think that restriction was implemented a little too tightly. :( non static or const contexts got the short end of that deal imho, but I dunno what kind of gymnastics the internals would require to allow what I want. And I worked around it with a custom instance method that I needed for other purposes anyway. 🤷