SOOOOOO after finally setting up my kbin dev environment I went ahead and wrote some code to add support for EXACTLY this on the official kbin codebase!
Now just need @ernest 's approval and once it's merged you'll be able to do this on kbin without any modifications!!!
edit: clicking on a comment now also hides its content (other than the username), making it even more clear which threads are collapsed! (similar to apollo) – updated the demo gif
I hope your PR gets approved, I was looking for this feature as I like the classic/tree view but it gets difficult to track new top-level comments as you scroll down the page.
Speaking of, pages are another thing I'd like the option to remove. I'd rather just have all the comments laid out in one page instead of having a pagination system, it makes Ctrl + F a lot handier in the future once places like these get even more critical mass.
Nice! Would it be possible to use a little +/- icon somewhere on each comment instead of having it be clicking anywhere on the comment? I could see myself very regularly accidentally collapsing stuff when I don't mean to.
I love the huge touch target for mobile friendliness, and I've done some work to make sure accidental collapses don't happen (if you mean to select text it won't collapse, if you click on a link or a button it won't collapse either!)
is there a common situation where you'd accidentally collapse stuff when you dont mean to?
Like @psyspoop said, touchpads can be prone to accidental collapses. Maybe setting the touch target to be on the "header" of the comment (the whitespace between the username and the upvote/downvote buttons) could be a good compromise?
TBH that's not too hard to do, but it goes back to the whole mobile friendliness :(
IMO i think the upside of mobile friendliness outweigh the times people accidentally tap on touchpad, and i personally think just having the header being a touch target is a little too small for mobile users.. so i prefer the whole comment being a target
obviously if folks disagree heavily i could probably adjust but i'm curious what @ernest thinks
What if there was an option somewhere to switch between the two? Mobile users could keep the full comment collapsing, and web users could switch to header-only collapsing.
I like how RIF (Reddit Is Fun) does it. If you click on a comment (or post on your front page), it reformats the comment box so that it opens up additional options. One of them happens to be collapse among other basic commands like reply, report, next parent comment, previous parent comment and stuff like that. It makes the comment and front page sections a little bit more compact and easy to read quickly without options cluttering the interface. The voting options are the only options that stick out without clicking on a comment so you can easily upvote/downvote and move on.
interesting, sounds closer to a complete redesign on how we see and interact with the comment – i mostly use apollo so i kinda took the design language there but def see what you're saying!
limiting my change to specifically comment thread collapsing since that sounds like a bigger overhaul!
Really just accidentally clicking while hovering over the comment, which is especially more likely when using a touchpad on a laptop. It may not be that big of an issue if you've handled stuff like links and highlighting, but I guess in my head I like having one clear spot to click to trigger a functionality, but I do see the reasoning now that you mention mobile, and I agree that having a tiny little icon would be way more annoying on mobile than the occasional misclick on desktop.
Ideally there'd also be a collapse button for desktop imo, so that I can keep my mouse somewhere where accidental clicks don't do anything which is personally what I prefer
I don't like the idea of clicking something every time. I like the RES implementation, where you just tick a checkbox once, in settings, to always collapse parent comments and their children as well. There's never a scenario where I want all the comments to be expanded by default.
check out /m/kbinStyles
there are scripts you can download to allow collapsing comment threads and to move the text box to the top of a thread for easier posting
check out https://codeberg.org/Kbin/kbin-core/issues
Ernest is the dev for kbin.social and this is the place to make requests and bug reports. I'd scan through the requests first before posting in case there is a duplicate request. if there is you can go in and write why you want it or upvote it there to increase visibility for the admin
Add comment