Images for our docs! A bit gnarly that hosting and linking our own images seems to be one of the better solutions: I would love first-class support. I'm not unsympathetic to Francois's concerns about alternative solutions, but I'm happy enough with this to get it unblocked and moving forward. If you have strong opinions about other solutions, please make a follow-up!
A helpful note about cranelift for our fast-compile docs. Handy enough, but needs rebasing. I pinged the author a while back: this one gets adopt me.
I really want to split out the "basic setup" from "tips and tricks for optimizing your workflow" better: I constantly see beginners tripping over the more advanced optional config. Well, not this PR's fault.
Speaking of which, better docs on how to set up the LLD linker for faster compiles. Great.
I agree with Francois's concerns about not wanting to duplicate this. As we get moving on the Contributing book, I want to get all of the ancillary docs out of the bevy repo and onto the website on some form.
Nice little grammar fix. Great, looks solid. Hugely useful to have community reviews for this stuff: good back-and-forth and now I can just press the button.
Aha, more work towards deduplicating information between the repo and the book. Great, I like this as a next step. We really should get the book off the ground soon. I'm rather busy and would like to focus on UI, but once the Contributing guide is off the ground we should have expertise and bandwidth to tackle that next.
A nice little bit of web-dev / static-site generator cleanup. Great, looks cleaner. Happy to merge this sort of work incrementally: it's much easier to review, test and revert.
Additional styling for our details fold-out in the various books. Looks pretty and it's a nice pattern. It's fun to see Cart in the comments here: he's actually a rather strong web dev with a great aesthetic sense.
Merging: I'm excited to see what this gets used for (and thrilled to see folks taking initiative to improve the book).
I'm quite pleased with how those changes went: it's much easier to understand the status at a glance now. Please do just update the tags if you see a mistake (and bug me for triage permissions if you want them).
Ah, circular primitives. Still not fixed up: the author is in the middle of a move so that's understandable. Slapping an Adopt-Me on this: it should be a straightforward but crunchy bit of work.
Ah cone meshing... This has been discussed to death, and I'm happy enough with the solution presented and the quality of the implementation. Merging :) I don't think this will be particularly widely used (this isn't a CSG CAD tool), but it's nice to have in for completeness.
A bug fix with regression tests? Be still my heart.
bevy_math is nice because of how easy it is to test (for the most part). In this case, we screwed up constructing bounding spheres for 3D triangles. That's fixed now, with tests to prove it. Love it: code review is abysmal for correctness verification. Write tests instead!
Ooh, depth of field post-processing effects! As a lover of photography, I'm thrilled to see this included: it's a fun physically-inspired artistic effect.
Great screenshots and PR description. I merged in a couple of trivial typo fixes, then kicked off a merge. There was one other meaningful follow-up about webgpu support that I didn't want to lose, so I spun that out into an easy follow-up issue.
The author has been frustrated by Bevy's reviews: compassion first.
And it's time for yet another rendering feature by the indomitable pcwalton: there's going to be about a dozen shiny PBR effects in the release notes at this point 😅
This one is volumetric fog, and the corresponding god rays. I love these: so pretty! Seriously, look at this.
Needs merge conflicts resolved: IceSentry made a PR to the PR to merge it in. Let's wait on the author to merge that in and double-check it.
Ah, glTF... There are so, so many textures supported, each of which modifies the distribution of another property.
This PR ensures that we can properly support using different UV sets for each property, bringing us into (better) compliance with the spec. Great; I hate it when imports are subtly broken. Really thorough and professional work. Merging.
This PR adds MSRV fields for our standalone crates, following a determination that this was out of date for the (cursed, neglected) bevy_mikktspace crate.
Originally this added an MSRV for every crate. Which, as Francois pointed out, wasn't super useful, since most of them aren't intended to be used by themselves. Tweaking the PR title and merging.
Improvements to our texture builder API. This is exactly what the Usability label exists for :D There's unresolved feedback though (go bikeshed this if you care about builder patterns): removing the S-Ready-for-Final-Review label and swapping to S-Waiting-For-Author.
A straightforward bug fix for rendering: we need to be sure that we apply transforms on the UV texture data consistently. Good catch and evidently obviously correct. Merge conflicts though, pinging the author.
More developer experience work: adding an alias to our local ci tool which runs all of the little checks locally.
Cute and useful: it's good to see this work getting prioritized by BD103 and crew. Not the most seamless workflow still, but I think we can get there :)
Oh! Exciting PR while I was gone! I spent several days porting all of our end user color types to LinearRgba, immediately hated how it looked, and it wasn't even measurably faster :( So, abandoning that, we decided to go all-in on making a useful, correct-by-default Color type that wraps the fancy typed color spaces.
This PR adds trait impls for all of the fancy things you might want to do, converting if needed before converting back. Very convenient! Merging!
Alright, that's all for this week's merge train :) I'm going to do a first pass of the 0.14 milestone for the remainder of my work day today. There's a ton built up: it's time to focus on nearly-ready work, critical fixes, and complementary efforts to our big pushes.
Tomorrow, we start the release notes and migration guide! Once that's done and the milestone is clear of critical bugs, it's time for a freeze and a release candidate. I'm excited to see how it goes.
@alice_i_cecile Welcome back! I was hoping to do some work splitting the migration guide process into smaller, more manageable pieces that can be divided across multiple people, but that probably won't be done for this release. Oh well :)
@alice_i_cecile abandoning stuff sure can feel demotivating, another perspective is you avoided taking a wrong path through experimentation, hence resulting in a better outcome! 👍
@alice_i_cecile
I know from experience how frustrating PR reviews can be. The procedure adds value but also increases the process and psychological burden. I like how the merge train is one mechanism to help counter some of the negatives. The comment "we could improve x and y but do that later, merge now" is one I enjoy seeing. I think some have the impression PR review needs to be an infinity gauntlet towards perfection.
Add comment