ian,
@ian@phpc.social avatar

Wanna help me get Joind.in's API to zero phpstan errors on PHP 8.2? https://github.com/joindin/joindin-api/pull/944

Got it down to a little under 600 with like three hours of effort, with tests still passing of course.

matthewtrask,
@matthewtrask@phpc.social avatar

@ian Im happy to pick up a few, but for some reason I can't branch off your branch on my local so lemme figure that out.

matthewtrask,
@matthewtrask@phpc.social avatar

@ian derp getting this:

ERROR: Permission to iansltx/joindin-api.git denied to matthewtrask.
fatal: Could not read from remote repository.

I forget is this on your side or mine?

ian,
@ian@phpc.social avatar

@matthewtrask Fork the repo in GitHub, then pull to local on the forked repo. You can edit the php82 branch locally and PR your php82 into my php82 if you like.

matthewtrask,
@matthewtrask@phpc.social avatar

@ian yea that makes sense, its been a while since I've done this lol

alessandrolai,
@alessandrolai@phpc.social avatar

@ian I'll give it a go, I have an hour to kill, and squashing PHPStan issues gives me some Marie-Kondo-style satisfaction 😆

ian,
@ian@phpc.social avatar

@alessandrolai Branch off @Synchro's PR heh

alessandrolai,
@alessandrolai@phpc.social avatar

@ian @Synchro Crap, too late 😅 well, this is my small bit of work, hope it's not wasted!

Synchro,
@Synchro@phpc.social avatar

@ian I'll have a look at this too.

herndlm,
@herndlm@phpc.social avatar

@ian how do you prefer people contributing? MRs against that MR branch or MRs after you merge that one? Any other rules to follow? I don't want to promise that I have time soon, but I might :)

ian,
@ian@phpc.social avatar

@herndlm In this case, if my branch still exists when you get around to it, PR against it. Normally I'd say just PR against the upstream but not sure quite when this will get merged.

maxtappenden,

@ian Oh, you make Joind.in? The slideshow viewer doesn’t work with screen magnification on mobile / tablet.

I might be able to help with that, if you’re interested.

ian,
@ian@phpc.social avatar

@maxtappenden we have a slideshow viewer?

But yes, PRs appreciated. Joindin-web2 would be the repo you're looking for.

maxtappenden,

@ian Well, you know, when you try to view slides, that doesn’t work with screen magnification on iOS or iPadOS (probably also Android — usually the case — but I haven’t checked).

I’ll take a look when I’m home next week.

ramsey,
@ramsey@phpc.social avatar

@maxtappenden @ian The slides link is just a URL provided by the speaker. It always takes you away to a different site, wherever the slides are hosted.

maxtappenden,

@ramsey @ian Does it? Shows how much attention I pay 🤷‍♂️

Do a lot of people use the same tool to host their slides? I’ve definitely viewed presentations from multiple people and had the same problem each time (basically you can’t pan around the screen with the magnifier without inadvertently activating the controls — this happens a lot with sloppy JavaScript libraries).

ian,
@ian@phpc.social avatar

@maxtappenden @ramsey Yeah, a lot of speakers use Speakerdeck/Slideshare, with some on Reveal.js. I use Slides.com.

maxtappenden,

@ian @ramsey That’ll be it, then. So it’s not something we can easily fix.

  • All
  • Subscribed
  • Moderated
  • Favorites
  • random
  • ngwrru68w68
  • rosin
  • GTA5RPClips
  • osvaldo12
  • love
  • Youngstown
  • slotface
  • khanakhh
  • everett
  • kavyap
  • mdbf
  • DreamBathrooms
  • thenastyranch
  • magazineikmin
  • megavids
  • InstantRegret
  • normalnudes
  • tacticalgear
  • cubers
  • ethstaker
  • modclub
  • cisconetworking
  • Durango
  • anitta
  • Leos
  • tester
  • provamag3
  • JUstTest
  • All magazines