draconik

@draconik@kbin.social
CodexArcanum, (edited )

As a senior at my last big company job, basically all I did was conduct meetings and do PRs. It’s such a grind.

My opinion now is that most PR is worthless anyway. Most people give, at best, a superficial skim for typos, lack of comments, or other low-hanging replies (that usually, really, a static checker or linter should be dealing with).

Reading the code base in little chunks like that doesn’t give you proper context for the changes you’re reading. Automated unit and integration tests would be better for catching issues like that, but of course then who is reviewing and verifying the tests? Who’s writing them for that matter?

Ideally, pair-programming or having extra people on projects to create knowledge redundancy would help. But companies want to replace juniors with AI now, so that’s not looking good. Senior devs and architects might know the major pieces of much of the code, but can they “load it into working memory” sufficiently to do a quality PR that will catch something the tests didn’t and QA wouldn’t? Not in my experience.

I think the best actually-implementable solution for most teams is to get rid of PR expectations and take a multi-pronged approach to replacing that process.

  1. use tooling to check for and fix basic stuff. Use a linter, adopt a code standard, get a code formatting tool that forced adherence to the standard and run it on every PR.
  2. Unit tests if you got them, start if you don’t. You don’t need 90% code coverage, just make sure critical paths are covered.
  3. Turn one of your useless meetings into a code review session. Each week/sprint, one Very Important Code section is presented by the developer that works on it most or that last changed it. This helps the whole team learn the code base, gets more eyes on the important stuff regularly, and enforces not just a consistent style but a consistent approach to solving and documenting problems.
  4. PR (and the github PR approval stuff or its equivalent for you) should be streamlined but preserved. Do have a second person approve changes before merging, just to double check that tests have finished and passed and all that. If your team is so busy that no one ever approves PRs then allow self-approval and be done with it. This will make regular code review very important for security and stability, since any dev could be misbehaving unseen, but these are the trade-offs you make when burning out your team is more important than quality.
scrubbles,
@scrubbles@poptalk.scrubbles.tech avatar

Shocking, the pandemic may have inflated the subscriber counts for them. Of course rather than see that and switch to a stable stock, they just have to have infinite growth, even though that’s ridiculous post pandemic

Maggoty,

Tensions are definitely higher than last decade and the decade before. The collapse of the Soviet Union and relatively good economy of the 1990s relieved a lot of tension.

But we’re still a ways from WW3. We’re back into a pretty normal range for the Cold War. We know China and Russia have the will and the means to try and expand. But they know we have the will and the means to stop them in certain places. That’s important because the first two world wars have very different start points that we aren’t close to meeting.

World War 1 was started by chains of alliances between countries. They were meant to keep balance but they were decentralized. So there was no committee ruling on Article 5 or bringing new members in. Which is how anarchists in Serbia set off the alliances like a chain of explosives. Both the CSTO and NATO contain rules preventing such a thing. WW1 was helped by cultural views on war. Europe hadn’t had a proper industrialized war yet. So everyone thought it was going to be another affair with picnics and a couple large set piece battles.

World War 2 was started by a specific ideology in a country run by meth heads. Hitler was as high as he was crazy. There were a lot of problems left over from World War 1 that gave him an opening but at the core of it all, if he had made a level headed assessment he’d have known he could never win against the US/UK/RUS alliance.

Neither Russia nor China wants the economic devastation that would result from a World War 3. They aren’t meth heads and the glory of war is long dead. There’s some rumors too that the Chinese are looking at what western equipment can do in Ukraine and they’re currently purging some officers who insisted we were exaggerating our capabilities. (They built plans and bought equipment over decades on those recommendations). Russia couldn’t invade a cardboard box much less a NATO country at this point.


Now, American Civil War 2. It’s not likely for two reasons. One, fighting a war is far more complicated than it used to be. You could gather a bunch of rifles and cannons to have a serious force in 1861. Now days whoever the Army sides with will win in hours. It’s not an exaggeration to say a militia could run off a town’s police force, set up checkpoints, and take over. But while they were celebrating they’d get hit by air to ground missiles and 25mm rounds from a single helicopter they will never see or hear. And they certainly won’t see the special forces team in the woods designating targets. If for some reason they did need to be engaged by the regular infantry it would not go well for them at all. They need to deal with drones, snipers, mortars, artillery, and light tanks. Furthermore there have been head to head practice fights between veterans and militias. (Reality TV in the 2000’s got wild.) It never ended well for the militia. They would be outmaneuvered, pinned down, and dead, in about 5 minutes.

Two, the modern model is terrorism. In a Civil War you need a large percentage of support. You have to field whole divisions and the logistics therein. But for political violence you need support from 10 percent of the population in a region to have places to hide and logistics. Also, you can cause havoc with a force the size of a company.

I would say it’s highly likely we’ll see more political violence before we either come back together as a country or we allow a region to become autonomous or even independent.

Google emails revealing disagreements b/w Product and Advertising teams about manipulating search to drive ad revenue (gizmodo.com.au)

tl/dr: email chains used as evidence in DOJ Google antitrust case show internal arguments about drops in # of searches, and how to increase them so that people see more ads. Search team wants to create better search results to keep people coming back....

Biblically accurate angels visit Bikini Bottom and other cursed locations

https://sopuli.xyz/pictrs/image/d201d4ba-e6f9-4281-ae38-9516c99e6b5c.jpeghttps://sopuli.xyz/pictrs/image/f32b5590-670c-4be2-a8ad-0ec403e47232.jpeghttps://sopuli.xyz/pictrs/image/d0aa54f3-dbfc-4543-8d8b-9772d2824ec6.jpeghttps://sopuli.xyz/pictrs/image/c2ffdcc7-0389-4e5f-8f0e-ce1dda35f680.jpeghttps://sopuli.xyz/pictrs/image/7f753fba-eae9-4839-b480-dd0a89360991.jpeghttps://sopuli.xyz/pictrs/image/d596c4a6-663b-403b-8c56-6f31176de7c3.jpeghttps://sopuli.xyz/pictrs/image/16db0a58-55ca-4028-8540-8bc28f1eaf99.jpeghttps://sopuli.xyz/pictrs/image/edc84961-d6cb-443b-adac-3c737bc555b6.jpeghttps://sopuli.xyz/pictrs/image/ec8f971b-9d75-489b-9962-d8358dd82835.jpeghttps://sopuli.xyz/pictrs/image/a15888fa-ce0d-4cda-ac31-508e09665ced.jpeghttps://sopuli.xyz/pictrs/image/ac7ed13e-6742-47ad-8334-361e83521117.jpeghttps://sopuli.xyz/pictrs/image/8f90c1c4-61ec-48f1-bcdc-8f4e68afa8db.jpeg...

What's, in your opinion, the android smartphone worth buying right now based on reparability, freedom of use and long term support?

These are the things i care the most: I want a smartphone i can repair on my own (battery and screen are the essential parts), with a bootloader easily unlockable, even better with verified boot / supporting a custom OS with re-lockable bootloader....

MemeCollector,
MemeCollector avatar

I don't disagree with your sentiment but please don't use ableist language here.

Arotrios,
Arotrios avatar

---Obligatory fuck Netflix post---

Watch anything you want super simple: https://movie-web.app/search/movie

Look for something to watch, less simple: https://goku.sx/home

Stream or torrent, use with a VPN if you download: https://github.com/popcorn-official/popcorn-desktop (scroll down for install files)


Canceled my sub a year ago (which had lasted since the Blockbuster days) when I heard about the changes and never looked back. Their horrible treatment of talent and their refusal to provide proper residuals is one of the main dynamics driving the SAG AFTRA strike. Imagine being a major actor in a show millions are actively watching, and your monthly check from it is $27.

Side note, Netflix has 3.5 billion in free cash on hand. Once the strike was announced, they scaled back their content investment and are now claiming 5 billion in cash reserves.

These fuckers can absolutely afford to pay their talent a living wage. Until they do, they aren't getting a dime from me.

Hackers already infiltrate EV chargers (grist.org)

one featured a picture of President Biden pointing his finger, with an “I did that!” caption. the hosts of The Kilowatts tweeted a video showing it was possible to take control of an Electrify America station’s operating system. cracks could conceivably permit hackers to access vehicle data or consumers’ credit card...

Since we need some discussion and activity, here are some of my must-watch tv shows.

Hi! I am normally not an active user, but I am definitely someone who spent countless hours watching TV shows. Since I have just recently joined Lemmy, thought I can share my all-time favorite TV shows and maybe be able to get one or two new shows and have a nice discussion about them. Here is the list:...

BiggestBulb,
BiggestBulb avatar

Just gonna drop Avatar: The Last Airbender in here.

Starts out a lil slow but it's an absolute masterpiece. It's also still pretty funny and entertaining in general as an adult

The Supreme Court is out of control and must be reformed (www.dailykos.com)

The majority then announced, with an opinion from Chief Justice John Roberts, that it was overthrowing the student loan forgiveness program, granting a request from six Republican state attorneys general on behalf of a loan servicer, the Missouri Higher Education Loan Authority, that did not want to be used as a plaintiff....

  • All
  • Subscribed
  • Moderated
  • Favorites
  • JUstTest
  • Leos
  • DreamBathrooms
  • thenastyranch
  • magazineikmin
  • osvaldo12
  • ethstaker
  • Youngstown
  • mdbf
  • slotface
  • rosin
  • ngwrru68w68
  • kavyap
  • cubers
  • anitta
  • modclub
  • InstantRegret
  • khanakhh
  • GTA5RPClips
  • everett
  • Durango
  • tacticalgear
  • provamag3
  • tester
  • cisconetworking
  • normalnudes
  • megavids
  • lostlight
  • All magazines