I've spent the last couple of evenings adding a new, pretty big feature. The net change in code is +3 lines. So, I deleted almost as much code as I added, in addition to what I rewrote.
I consider that a good pull request! 😁
The code i edited was pretty old, and had more complexity than the recent implementation needed. So a bit of legacy there too to be honest. Still ...
By the way, the feature I've added is this: In my app you can give documents a status icon that previously only took colour values. A user suggested to allow for shapes as well, and I really liked the idea. Here's the new dialog with the shape options.
@robchapman It won't be included until next release, but yeah, I think it will be very useful. I'm already testing it on my own projects. The bars are nice for tracking drafts.
The shapes are generated in polar coordinates in a cache of QPainterPath objects. That part was particularly fun, because I got to refresh some middle school geometry skills. 😁
@nesevis Yes, that was the original motivation. But even with good colour vision, distinguishing colour on icons can be tricky when there's a lot of them since human colour perception is relative to surroundings.
Add comment