rob,
@rob@akrabat.com avatar

In my experience, multiple concepts invariably end up in a non-trivial PR. When a repository uses squash-and-merge then those concepts end up in the same single commit on main and any context is lost.

https://indieweb.social/@lornajane/111425261462048360

Girgias,
@Girgias@phpc.social avatar

@rob I think squash and merge is a good default policy for PRs as you can do fix-up commits without needing to rebase, force push, and confuse the reviewer to make sure the requested changes went through.

But, sometimes rebasing the PR and merging it as multiple commits is the best way to go.

rob,
@rob@akrabat.com avatar

@Girgias I would rather have the fix-up commits in history, rather than one commit that can't be unpicked.

Girgias,
@Girgias@phpc.social avatar

@rob depends on the nature of the fix-up really, but then php-src is pretty bad in regards to atomic commits.

  • All
  • Subscribed
  • Moderated
  • Favorites
  • random
  • DreamBathrooms
  • mdbf
  • ethstaker
  • magazineikmin
  • GTA5RPClips
  • rosin
  • thenastyranch
  • Youngstown
  • osvaldo12
  • slotface
  • khanakhh
  • kavyap
  • InstantRegret
  • Durango
  • megavids
  • everett
  • tester
  • cisconetworking
  • Leos
  • cubers
  • modclub
  • ngwrru68w68
  • tacticalgear
  • anitta
  • provamag3
  • normalnudes
  • JUstTest
  • lostlight
  • All magazines