PSA: Do not submit "omnibus" pull requests to #git repos, especially without talking to the maintainer first. Keeping PRs generally focused to one particular problem or feature makes things far more manageable for reviewing, testing, and reverting/bug-fixing later on. I would always much rather have 10 smaller PRs focused one specific thing each than one massive unsolicited one with a bunch of scope creep.
This will also potentially save you some hurt feelings since I'm sure it was a lot of effort to write those 2000 LOC changes that might now sit forever because very few maintainers have the time or capacity to review all of that.
Add comment