velkuns, 4 months ago

@dseguy try/finally could be useful in some specifics cases 😁

dseguy, 4 months ago

@velkuns I like the idea, though I'd be hard pressed to find one example.
Let me make this an @Exakat rule and see who get caught in that net first.

dseguy, 4 months ago

@velkuns @Exakat It took 20 mins to write the rule and start auditing, but I already have the first results :

https://github.com/snc/SncRedisBundle/blob/master/src/Logger/RedisCallInterceptor.php

so, it might be more often than I though.

velkuns, 4 months ago

@dseguy @Exakat 👍

dseguy, 4 months ago

@velkuns @Exakat I'm getting more results, and it seems quite common, in fact.

May be even more than a __destruct() function.

May be I'll take some time to review them.

velkuns, 4 months ago

@dseguy @Exakat one use case in mind is when I open a resource (file for example).

I need to close it in any case. But not necessary to catch any exception. So just try/finally can help to avoid duplicate code to close the resource.

dseguy, 4 months ago

@velkuns @Exakat I am thinking about external resources that needs to be finished absolutely, like XML file (closing all tags before the file).

I'm also thinking about releasing stuff, like a lock or a connexion before moving on.

velkuns, 4 months ago

@dseguy @Exakat yes.

Lots of use cases, finally 😁

Thanks to PHP to permit this kind of thing ❤️