derickr, 5 months ago

@nyamsprod I bet you could make a patch!

nyamsprod, 5 months ago

@derickr I wish I could really

derickr, 5 months ago

@nyamsprod You can give it a try? Happy to be a guide

Girgias, 5 months ago

@nyamsprod @derickr the base 32 ones shouldn't be too difficult to do, type aliases are a different level of conplexi tho :-/

nyamsprod, 5 months ago

@Girgias @derickr here's a simple proposition not entirely flesh out. Still rough but a general idea to think about let me know your thought https://gist.github.com/nyamsprod/8a5cf21c136952a46ec8836f29738c82

derickr, 5 months ago

@nyamsprod @Girgias I'll get to a full response after the break, but I think I'd be in favour of just the simple functions.

nyamsprod, 5 months ago

@derickr @Girgias no problem take your time I wanted to put my thoughts into words before the break and yes the proposal can evolve

derickr, 5 months ago

@nyamsprod @Girgias Alright, I just had a longer look, and (of course) found that base32 is more complicated than expected:

1. There are two standards in RFC4648.
2. A bunch of other mappings are also common: https://en.wikipedia.org/wiki/Base32#Alternative_encoding_schemes
3. accepting strings with 0, 1, 8, l, L, might require allowing for user-defined mappings.

Ideally the API looks the same as for base64, but I think it would be too simple to allow for all requirements. I wouldn't want to see a class for this though.

nyamsprod, 5 months ago

@derickr @Girgias did you have a chance to check how Python did it ? They use to have functions with signature similar to our current base64 approach but they did revamp the API https://docs.python.org/3/library/base64.html
Again I am not sure as you said that all should be covered but I believe being able to encode/decode hex and ascii should be possible natively

derickr, 5 months ago

@nyamsprod @Girgias I did check python, but found it rather clunky 🙂

nyamsprod, 5 months ago

@derickr @Girgias If we stick with functions a la base64 we then need to add extra variables - the alphabet and maybe the padding character. so that user land can switch the alphabet and/or the padding character as they want PHP would only provide the Hex and Us-Ascii alphabet (those from the RFC)
So for encoding you would have at most 3 parameters and 4 on decode.

nyamsprod, 5 months ago

@derickr @Girgias following our last discussion I createed a polyfill using functions only let me know if this is what you had in mind. https://github.com/bakame-php/aide/tree/main/src/Base32
The implementation does not really matter what matter most is the API

nyamsprod, 5 months ago

@derickr the best I could do is maybe creating the RFC and probably help with building the test suite but my knowledge of C is really not that great. Might be a goal for 2024 (talking about base32) type alias requires I believe a deeper knowledge of PHP internals that I really do not have

derickr, 5 months ago

@nyamsprod Type alias i agree with, but base32 should be possible :-) Happy to help

timwolla, 5 months ago

@nyamsprod Agreed with regard to base32. Though my use cases so far have all been security-sensitive (TOTP secrets), thus needing to use https://github.com/paragonie/constant_time_encoding anyway.