I'm a big proponent of doing fewer if statements and early returns! Doing stuff in your if statements only increases cognitive load when trying to read the code.
public function sendActivationEmail($user) {
if (! $user->isActivated) {
// Send out activation email
}
}
versus.
public function sendActivationEmail($user) {
if ($user->isActivated) {
return;
}
@Joe_C_London yes exactly. When I got to work on that piece of code, the first thing I did was refactor it because, oh my .... That was unbearable to interpret.
@SuitedUpDev I've been a long time fan of these ways to end up with cleaner code. I'd also call it "tell, don't ask" as in "Do something - if it needs to happen".
Its almost like a lot of the refactoring & simplifying code that I do, is extracting functions and inverting conditions (sometimes extracting complex conditionals). Either way, with some decent method names, the end result is so much easier to understand - and you can still dive deeper to get the nitty-gritty.
and once you've dedicated yourself to the religion of nesting only when necessary, there really are some good techniques you discover out of pure stubbornness!
Add comment